ksmbd: Fix resource leak in ksmbd_session_rpc_open()

[ Upstream commit bc044414fa0326a4e5c3c509c00b1fcaf621b5f4 ]

When ksmbd_rpc_open() fails then it must call ksmbd_rpc_id_free() to
undo the result of ksmbd_ipc_id_alloc().

Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/fs/ksmbd/mgmt/user_session.c b/fs/ksmbd/mgmt/user_session.c
index 8d8ffd8c6f1929ef2b73740dcb4aca3f0d847f6b..0fa467f2c897378f14d99ea7d8a5a5e0cead9496 100644 (file)
--- a/fs/ksmbd/mgmt/user_session.c
+++ b/fs/ksmbd/mgmt/user_session.c
@@ -106,15 +106,17 @@ int ksmbd_session_rpc_open(struct ksmbd_session *sess, char *rpc_name)
        entry->method = method;
        entry->id = ksmbd_ipc_id_alloc();
        if (entry->id < 0)
-               goto error;
+               goto free_entry;
 
        resp = ksmbd_rpc_open(sess, entry->id);
        if (!resp)
-               goto error;
+               goto free_id;
 
        kvfree(resp);
        return entry->id;
-error:
+free_id:
+       ksmbd_rpc_id_free(entry->id);
+free_entry:
        list_del(&entry->list);
        kfree(entry);
        return -EINVAL;