staging: qlge: Replace strncpy with strscpy
authorRicardo Lopes <ricardoapl.dev@gmail.com>
Fri, 6 Oct 2023 16:12:24 +0000 (17:12 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 7 Oct 2023 09:13:49 +0000 (11:13 +0200)
Reported by checkpatch:

WARNING: Prefer strscpy, strscpy_pad, or __nonstring over strncpy

Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
Link: https://lore.kernel.org/r/20231006161240.28048-1-ricardoapl.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/qlge/qlge_dbg.c

index c7e865f515cf75697dbf9b86eb2f5ac1db8620ec..5f08a8492da4fc3d2d529001eae88bd0160592fa 100644 (file)
@@ -696,7 +696,7 @@ static void qlge_build_coredump_seg_header(struct mpi_coredump_segment_header *s
        seg_hdr->cookie = MPI_COREDUMP_COOKIE;
        seg_hdr->seg_num = seg_number;
        seg_hdr->seg_size = seg_size;
-       strncpy(seg_hdr->description, desc, (sizeof(seg_hdr->description)) - 1);
+       strscpy(seg_hdr->description, desc, sizeof(seg_hdr->description));
 }
 
 /*
@@ -737,7 +737,7 @@ int qlge_core_dump(struct qlge_adapter *qdev, struct qlge_mpi_coredump *mpi_core
                sizeof(struct mpi_coredump_global_header);
        mpi_coredump->mpi_global_header.image_size =
                sizeof(struct qlge_mpi_coredump);
-       strncpy(mpi_coredump->mpi_global_header.id_string, "MPI Coredump",
+       strscpy(mpi_coredump->mpi_global_header.id_string, "MPI Coredump",
                sizeof(mpi_coredump->mpi_global_header.id_string));
 
        /* Get generic NIC reg dump */
@@ -1225,7 +1225,7 @@ static void qlge_gen_reg_dump(struct qlge_adapter *qdev,
                sizeof(struct mpi_coredump_global_header);
        mpi_coredump->mpi_global_header.image_size =
                sizeof(struct qlge_reg_dump);
-       strncpy(mpi_coredump->mpi_global_header.id_string, "MPI Coredump",
+       strscpy(mpi_coredump->mpi_global_header.id_string, "MPI Coredump",
                sizeof(mpi_coredump->mpi_global_header.id_string));
 
        /* segment 16 */