opp: Fix adding OPP entries in a wrong order if rate is unavailable

Fix adding OPP entries in a wrong (opposite) order if OPP rate is
unavailable. The OPP comparison was erroneously skipped, thus OPPs
were left unsorted.

Tested-by: Peter Geis <pgwipeout@gmail.com>
Tested-by: Nicolas Chauvet <kwizart@gmail.com>
Tested-by: Matt Merhar <mattmerhar@protonmail.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

diff --git a/drivers/opp/core.c b/drivers/opp/core.c
index 8c905aabacc01aeee5d35501525ae4485913ea0e..5793c833b86ab481624135525e65e6dfd98daf50 100644 (file)
--- a/drivers/opp/core.c
+++ b/drivers/opp/core.c
@@ -1527,12 +1527,10 @@ int _opp_add(struct device *dev, struct dev_pm_opp *new_opp,
        mutex_lock(&opp_table->lock);
        head = &opp_table->opp_list;
 
-       if (likely(!rate_not_available)) {
-               ret = _opp_is_duplicate(dev, new_opp, opp_table, &head);
-               if (ret) {
-                       mutex_unlock(&opp_table->lock);
-                       return ret;
-               }
+       ret = _opp_is_duplicate(dev, new_opp, opp_table, &head);
+       if (ret) {
+               mutex_unlock(&opp_table->lock);
+               return ret;
        }
 
        list_add(&new_opp->node, head);