coresight: ultrasoc-smb: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Reviewed-by: James Clark <james.clark@arm.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20231116173301.708873-14-u.kleine-koenig@pengutronix.de

diff --git a/drivers/hwtracing/coresight/ultrasoc-smb.c b/drivers/hwtracing/coresight/ultrasoc-smb.c
index 6e32d31a95fe0865f96d09c1c83fd2e272e2ac31..2092433ff86e5e5e7eaa38a3668b802e1a425db0 100644 (file)
--- a/drivers/hwtracing/coresight/ultrasoc-smb.c
+++ b/drivers/hwtracing/coresight/ultrasoc-smb.c
@@ -601,15 +601,13 @@ static int smb_probe(struct platform_device *pdev)
        return 0;
 }
 
-static int smb_remove(struct platform_device *pdev)
+static void smb_remove(struct platform_device *pdev)
 {
        struct smb_drv_data *drvdata = platform_get_drvdata(pdev);
 
        smb_unregister_sink(drvdata);
 
        smb_config_inport(&pdev->dev, false);
-
-       return 0;
 }
 
 #ifdef CONFIG_ACPI
@@ -627,7 +625,7 @@ static struct platform_driver smb_driver = {
                .suppress_bind_attrs = true,
        },
        .probe = smb_probe,
-       .remove = smb_remove,
+       .remove_new = smb_remove,
 };
 module_platform_driver(smb_driver);