hw/misc/stm32l4x5_rcc: Propagate period when enabling a clock
authorArnaud Minier <arnaud.minier@telecom-paris.fr>
Sun, 17 Mar 2024 10:39:12 +0000 (11:39 +0100)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 26 Mar 2024 13:24:06 +0000 (14:24 +0100)
The "clock_set_mul_div" function doesn't propagate the clock period
to the children if it is changed (e.g. by enabling/disabling a clock
multiplexer).
This was overlooked during the implementation due to late changes.

This commit propagates the change if the multiplier or divider changes.

Fixes: ec7d83acbd ("hw/misc/stm32l4x5_rcc: Add an internal clock multiplexer object")
Signed-off-by: Arnaud Minier <arnaud.minier@telecom-paris.fr>
Signed-off-by: Inès Varhol <ines.varhol@telecom-paris.fr>
Message-ID: <20240317103918.44375-2-arnaud.minier@telecom-paris.fr>
[PMD: Check clock_set_mul_div() return value]
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20240325152827.73817-4-philmd@linaro.org>

hw/misc/stm32l4x5_rcc.c

index 49b90afdf0fb196da5ec5c7c49f3367c208d4a4f..ed2dbd9dc3f4eb686a474fe65cda94950d8615c0 100644 (file)
@@ -61,7 +61,7 @@ static void clock_mux_update(RccClockMuxState *mux, bool bypass_source)
         freq_multiplier = mux->divider;
     }
 
-    clock_set_mul_div(mux->out, freq_multiplier, mux->multiplier);
+    clk_changed |= clock_set_mul_div(mux->out, freq_multiplier, mux->multiplier);
     clk_changed |= clock_set(mux->out, clock_get(current_source));
     if (clk_changed) {
         clock_propagate(mux->out);