selftests/cgroup: cpu_hogger init: use {} instead of {NULL}
authorJohn Hubbard <jhubbard@nvidia.com>
Fri, 3 May 2024 03:51:04 +0000 (20:51 -0700)
committerTejun Heo <tj@kernel.org>
Fri, 3 May 2024 19:06:09 +0000 (09:06 -1000)
First of all, in order to build with clang at all, one must first apply
Valentin Obst's build fix for LLVM [1]. Once that is done, then when
building with clang, via:

    make LLVM=1 -C tools/testing/selftests

...clang generates warning here, because struct cpu_hogger has multiple
fields, and the code is initializing an array of these structs, and it
is incorrect to specify a single NULL value as the initializer.

Fix this by initializing with {}, so that the compiler knows to use
default initializer values for all fields in each array entry.

[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/

Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>
Signed-off-by: Tejun Heo <tj@kernel.org>
tools/testing/selftests/cgroup/test_cpu.c

index 186bf96f6a284651b9953d75a1f91806db118821..dad2ed82f3ef7c0996d79333f72384941ee76c70 100644 (file)
@@ -237,7 +237,7 @@ run_cpucg_weight_test(
 {
        int ret = KSFT_FAIL, i;
        char *parent = NULL;
-       struct cpu_hogger children[3] = {NULL};
+       struct cpu_hogger children[3] = {};
 
        parent = cg_name(root, "cpucg_test_0");
        if (!parent)
@@ -408,7 +408,7 @@ run_cpucg_nested_weight_test(const char *root, bool overprovisioned)
 {
        int ret = KSFT_FAIL, i;
        char *parent = NULL, *child = NULL;
-       struct cpu_hogger leaf[3] = {NULL};
+       struct cpu_hogger leaf[3] = {};
        long nested_leaf_usage, child_usage;
        int nprocs = get_nprocs();