Input: melfas-mip4 - use device core to create driver-specific device attributes

Instead of creating driver-specific device attributes with
devm_device_add_group() have device core do this by setting up dev_groups
pointer in the driver structure.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20230729005133.1095051-16-dmitry.torokhov@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c
index 2ac4483fbc2588b552ef9c76f40caa7f51978036..aa325486f61825e2e30d36a432fffafd8ddb2cbb 100644 (file)
--- a/drivers/input/touchscreen/melfas_mip4.c
+++ b/drivers/input/touchscreen/melfas_mip4.c
@@ -1419,10 +1419,7 @@ static struct attribute *mip4_attrs[] = {
        &dev_attr_update_fw.attr,
        NULL,
 };
-
-static const struct attribute_group mip4_attr_group = {
-       .attrs = mip4_attrs,
-};
+ATTRIBUTE_GROUPS(mip4);
 
 static int mip4_probe(struct i2c_client *client)
 {
@@ -1514,13 +1511,6 @@ static int mip4_probe(struct i2c_client *client)
                return error;
        }
 
-       error = devm_device_add_group(&client->dev, &mip4_attr_group);
-       if (error) {
-               dev_err(&client->dev,
-                       "Failed to create sysfs attribute group: %d\n", error);
-               return error;
-       }
-
        return 0;
 }
 
@@ -1589,6 +1579,7 @@ static struct i2c_driver mip4_driver = {
        .probe = mip4_probe,
        .driver = {
                .name = MIP4_DEVICE_NAME,
+               .dev_groups = mip4_groups,
                .of_match_table = of_match_ptr(mip4_of_match),
                .acpi_match_table = ACPI_PTR(mip4_acpi_match),
                .pm = pm_sleep_ptr(&mip4_pm_ops),