mtd: maps: Fix refcount leak in of_flash_probe_versatile
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 23 May 2022 14:02:05 +0000 (18:02 +0400)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Mon, 6 Jun 2022 12:54:32 +0000 (14:54 +0200)
of_find_matching_node_and_match() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: b0afd44bc192 ("mtd: physmap_of: add a hook for Versatile write protection")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20220523140205.48625-1-linmq006@gmail.com
drivers/mtd/maps/physmap-versatile.c

index ad7cd9cfaee04908010ce5be6d6778deceb25f6e..297a509573567030495c5b5df2e96a16c43c45bf 100644 (file)
@@ -207,6 +207,7 @@ int of_flash_probe_versatile(struct platform_device *pdev,
 
                versatile_flashprot = (enum versatile_flashprot)devid->data;
                rmap = syscon_node_to_regmap(sysnp);
+               of_node_put(sysnp);
                if (IS_ERR(rmap))
                        return PTR_ERR(rmap);