misc: pci_endpoint_test: Remove unnecessary verification
authorGustavo Pimentel <Gustavo.Pimentel@synopsys.com>
Wed, 21 Oct 2020 21:28:10 +0000 (23:28 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 3 Nov 2020 09:11:44 +0000 (10:11 +0100)
The first condition of the if statement can never be true, because
bar variable is an enum variable type defined between 0 and 5, and
also bar variable acquires the value from arg function parameter which
is an unsigned long variable.

The constant 5 was replaced the the equivalent enum type, in this case
BAR_5.

Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Link: https://lore.kernel.org/r/142cbbc215bed4243a219ea17b46f4256ceccb22.1603315690.git.gustavo.pimentel@synopsys.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/pci_endpoint_test.c

index 146ca6fb3260f32a581ae942da98cddb0dce9baf..ea9c2c0852989d07d0613acc8b99558d94032df6 100644 (file)
@@ -708,7 +708,7 @@ static long pci_endpoint_test_ioctl(struct file *file, unsigned int cmd,
        switch (cmd) {
        case PCITEST_BAR:
                bar = arg;
-               if (bar < 0 || bar > 5)
+               if (bar > BAR_5)
                        goto ret;
                if (is_am654_pci_dev(pdev) && bar == BAR_0)
                        goto ret;