virtio_pci: use helper function is_power_of_2()
authorShaoqin Huang <shaoqin.huang@intel.com>
Fri, 21 Oct 2022 06:27:33 +0000 (23:27 -0700)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 28 Dec 2022 10:28:09 +0000 (05:28 -0500)
Use helper function is_power_of_2() to check if num is power of two.
Minor readability improvement.

Signed-off-by: Shaoqin Huang <shaoqin.huang@intel.com>
Message-Id: <20221021062734.228881-2-shaoqin.huang@intel.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
drivers/virtio/virtio_pci_modern.c

index c3b9f27618497a54a13b367445542ae163961918..207294bd7b9d678acd853bf2efcf72c0f6e568cc 100644 (file)
@@ -310,7 +310,7 @@ static struct virtqueue *setup_vq(struct virtio_pci_device *vp_dev,
        if (!num || vp_modern_get_queue_enable(mdev, index))
                return ERR_PTR(-ENOENT);
 
-       if (num & (num - 1)) {
+       if (!is_power_of_2(num)) {
                dev_warn(&vp_dev->pci_dev->dev, "bad queue size %u", num);
                return ERR_PTR(-EINVAL);
        }