migrate-bitmaps-postcopy-test: check that we can't remove in-flight bitmaps
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Mon, 22 Mar 2021 09:49:06 +0000 (12:49 +0300)
committerStefan Hajnoczi <stefanha@redhat.com>
Wed, 24 Mar 2021 13:41:19 +0000 (13:41 +0000)
Check that we can't remove bitmaps being migrated on destination vm.
The new check proves that previous commit helps.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20210322094906.5079-3-vsementsov@virtuozzo.com>

tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test

index d046ebeb949c6abae79ff8e749e862db3bd6824d..584062b4128830fe7e141db608869bc10bed9521 100755 (executable)
@@ -224,6 +224,16 @@ class TestDirtyBitmapPostcopyMigration(iotests.QMPTestCase):
         self.start_postcopy()
 
         self.vm_b_events += self.vm_b.get_qmp_events()
+
+        # While being here, let's check that we can't remove in-flight bitmaps.
+        for vm in (self.vm_a, self.vm_b):
+            for i in range(0, nb_bitmaps):
+                result = vm.qmp('block-dirty-bitmap-remove', node='drive0',
+                                name=f'bitmap{i}')
+                self.assert_qmp(result, 'error/desc',
+                                f"Bitmap 'bitmap{i}' is currently in use by "
+                                "another operation and cannot be used")
+
         self.vm_b.shutdown()
         # recreate vm_b, so there is no incoming option, which prevents
         # loading bitmaps from disk