mmc: sdhci-of-dwcmshc: fix error return code in dwcmshc_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Tue, 23 Mar 2021 11:29:56 +0000 (11:29 +0000)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 30 Mar 2021 09:42:07 +0000 (11:42 +0200)
Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: c2c4da37837e ("mmc: sdhci-of-dwcmshc: add rockchip platform support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20210323112956.1016884-1-weiyongjun1@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-of-dwcmshc.c

index 1113a56fe174800167dea2e8e95d36a2aaeddecd..34d26e3884a00bc8ee0ed762b9a981134874cfc8 100644 (file)
@@ -404,8 +404,10 @@ static int dwcmshc_probe(struct platform_device *pdev)
 
        if (pltfm_data == &sdhci_dwcmshc_rk3568_pdata) {
                rk_priv = devm_kzalloc(&pdev->dev, sizeof(struct rk3568_priv), GFP_KERNEL);
-               if (!rk_priv)
+               if (!rk_priv) {
+                       err = -ENOMEM;
                        goto err_clk;
+               }
 
                priv->priv = rk_priv;