ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_queue()
authorJules Irenge <jbi.octave@gmail.com>
Wed, 11 Mar 2020 01:09:07 +0000 (01:09 +0000)
committerTakashi Iwai <tiwai@suse.de>
Wed, 11 Mar 2020 06:55:18 +0000 (07:55 +0100)
Sparse reports a warning at tscm_hwdep_read_queue()

warning: context imbalance in tscm_hwdep_read_queue() - unexpected unlock

The root cause is the missing annotation at tscm_hwdep_read_queue()
Add the missing __releases(&tscm->lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20200311010908.42366-8-jbi.octave@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/tascam/tascam-hwdep.c

index c29a97f6f63888291d2595258011c7b8fde13829..9801e33e7f2a30d58c7d58297bc601a532f1a21a 100644 (file)
@@ -36,6 +36,7 @@ static long tscm_hwdep_read_locked(struct snd_tscm *tscm, char __user *buf,
 
 static long tscm_hwdep_read_queue(struct snd_tscm *tscm, char __user *buf,
                                  long remained, loff_t *offset)
+       __releases(&tscm->lock)
 {
        char __user *pos = buf;
        unsigned int type = SNDRV_FIREWIRE_EVENT_TASCAM_CONTROL;