ksmbd: retrieve number of blocks using vfs_getattr in set_file_allocation_info

Use vfs_getattr() to retrieve stat information, rather than make
assumptions about how a filesystem fills inode structs.

Cc: stable@vger.kernel.org
Signed-off-by: Marios Makassikis <mmakassikis@freebox.fr>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
index f6cc5d2730ffb741ee4d41c8068c0f1f13b12ba1..199c31c275e5bef4230ea97f26169ee91965714a 100644 (file)
--- a/fs/smb/server/smb2pdu.c
+++ b/fs/smb/server/smb2pdu.c
@@ -5809,15 +5809,21 @@ static int set_file_allocation_info(struct ksmbd_work *work,
 
        loff_t alloc_blks;
        struct inode *inode;
+       struct kstat stat;
        int rc;
 
        if (!(fp->daccess & FILE_WRITE_DATA_LE))
                return -EACCES;
 
+       rc = vfs_getattr(&fp->filp->f_path, &stat, STATX_BASIC_STATS,
+                        AT_STATX_SYNC_AS_STAT);
+       if (rc)
+               return rc;
+
        alloc_blks = (le64_to_cpu(file_alloc_info->AllocationSize) + 511) >> 9;
        inode = file_inode(fp->filp);
 
-       if (alloc_blks > inode->i_blocks) {
+       if (alloc_blks > stat.blocks) {
                smb_break_all_levII_oplock(work, fp, 1);
                rc = vfs_fallocate(fp->filp, FALLOC_FL_KEEP_SIZE, 0,
                                   alloc_blks * 512);
@@ -5825,7 +5831,7 @@ static int set_file_allocation_info(struct ksmbd_work *work,
                        pr_err("vfs_fallocate is failed : %d\n", rc);
                        return rc;
                }
-       } else if (alloc_blks < inode->i_blocks) {
+       } else if (alloc_blks < stat.blocks) {
                loff_t size;
 
                /*