x86/srso: Move retbleed IBPB check into existing 'has_microcode' code block
authorJosh Poimboeuf <jpoimboe@kernel.org>
Tue, 5 Sep 2023 05:04:59 +0000 (22:04 -0700)
committerBorislav Petkov (AMD) <bp@alien8.de>
Fri, 20 Oct 2023 10:29:25 +0000 (12:29 +0200)
Simplify the code flow a bit by moving the retbleed IBPB check into the
existing 'has_microcode' block.

Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Acked-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/0a22b86b1f6b07f9046a9ab763fc0e0d1b7a91d4.1693889988.git.jpoimboe@kernel.org
arch/x86/kernel/cpu/bugs.c

index 941ac94ad0d472f19e0cdbbb4ace76a476fc0a66..6b443f0fde342051d19de32a85b8d5295aa85f0f 100644 (file)
@@ -2430,10 +2430,8 @@ static void __init srso_select_mitigation(void)
                        setup_force_cpu_cap(X86_FEATURE_SRSO_NO);
                        return;
                }
-       }
 
-       if (retbleed_mitigation == RETBLEED_MITIGATION_IBPB) {
-               if (has_microcode) {
+               if (retbleed_mitigation == RETBLEED_MITIGATION_IBPB) {
                        srso_mitigation = SRSO_MITIGATION_IBPB;
                        goto out;
                }