selftests/powerpc: ptrace-pkey: Don't update expected UAMOR value
authorAneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Thu, 9 Jul 2020 03:29:45 +0000 (08:59 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 21 Jul 2020 14:01:06 +0000 (00:01 +1000)
With commit 4a4a5e5d2aad ("powerpc/pkeys: key allocation/deallocation
must not change pkey registers") we are not updating UAMOR on key
allocation. So don't update the expected uamor value in the test.

Fixes: 4a4a5e5d2aad ("powerpc/pkeys: key allocation/deallocation must not change pkey registers")
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200709032946.881753-23-aneesh.kumar@linux.ibm.com
tools/testing/selftests/powerpc/ptrace/ptrace-pkey.c

index 80dc5085a412dfd15af8333e2d6563cdf203dd3f..bc454f8991246560a7236db3fdec76205475e000 100644 (file)
@@ -101,15 +101,20 @@ static int child(struct shared_info *info)
         */
        info->invalid_amr = info->amr2 | (~0x0UL & ~info->expected_uamor);
 
+       /*
+        * if PKEY_DISABLE_EXECUTE succeeded we should update the expected_iamr
+        */
        if (disable_execute)
                info->expected_iamr |= 1ul << pkeyshift(pkey1);
        else
                info->expected_iamr &= ~(1ul << pkeyshift(pkey1));
 
-       info->expected_iamr &= ~(1ul << pkeyshift(pkey2) | 1ul << pkeyshift(pkey3));
+       /*
+        * We allocated pkey2 and pkey 3 above. Clear the IAMR bits.
+        */
+       info->expected_iamr &= ~(1ul << pkeyshift(pkey2));
+       info->expected_iamr &= ~(1ul << pkeyshift(pkey3));
 
-       info->expected_uamor |= 3ul << pkeyshift(pkey1) |
-                               3ul << pkeyshift(pkey2);
        /*
         * Create an IAMR value different from expected value.
         * Kernel will reject an IAMR and UAMOR change.