ALSA: usb-audio: Fix OOB access at proc output
authorTakashi Iwai <tiwai@suse.de>
Tue, 22 Jun 2021 09:06:47 +0000 (11:06 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 22 Jun 2021 09:08:27 +0000 (11:08 +0200)
At extending the available mixer values for 32bit types, we forgot to
add the corresponding entries for the format dump in the proc output.
This may result in OOB access.  Here adds the missing entries.

Fixes: bc18e31c3042 ("ALSA: usb-audio: Fix parameter block size for UAC2 control requests")
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210622090647.14021-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/mixer.c

index 428d581f988fe70125025a5175c9dadd821ed580..4ea4875abdf8f2b989efbbb3b1a63a43b8f1fd31 100644 (file)
@@ -3294,8 +3294,9 @@ static void snd_usb_mixer_dump_cval(struct snd_info_buffer *buffer,
                                    struct usb_mixer_elem_list *list)
 {
        struct usb_mixer_elem_info *cval = mixer_elem_list_to_info(list);
-       static const char * const val_types[] = {"BOOLEAN", "INV_BOOLEAN",
-                                   "S8", "U8", "S16", "U16"};
+       static const char * const val_types[] = {
+               "BOOLEAN", "INV_BOOLEAN", "S8", "U8", "S16", "U16", "S32", "U32",
+       };
        snd_iprintf(buffer, "    Info: id=%i, control=%i, cmask=0x%x, "
                            "channels=%i, type=\"%s\"\n", cval->head.id,
                            cval->control, cval->cmask, cval->channels,