fsi: cleanup extern usage in function definition
authorTom Rix <trix@redhat.com>
Sun, 3 Apr 2022 14:09:37 +0000 (10:09 -0400)
committerJoel Stanley <joel@jms.id.au>
Wed, 28 Sep 2022 11:40:57 +0000 (21:10 +0930)
Smatch reports these issues
fsi-core.c:395:12: warning: function 'fsi_slave_claim_range'
  with external linkage has definition
fsi-core.c:409:13: warning: function 'fsi_slave_release_range'
  with external linkage has definition

The storage-class-specifier extern is not needed in a
definition, so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20220403140937.3833578-1-trix@redhat.com
Signed-off-by: Joel Stanley <joel@jms.id.au>
drivers/fsi/fsi-core.c

index 3a7b78e3670118d32bacc5cce1454a65177ba864..0d11a17c53a0d23ec570f087152b26a41a896b8e 100644 (file)
@@ -392,8 +392,8 @@ int fsi_slave_write(struct fsi_slave *slave, uint32_t addr,
 }
 EXPORT_SYMBOL_GPL(fsi_slave_write);
 
-extern int fsi_slave_claim_range(struct fsi_slave *slave,
-               uint32_t addr, uint32_t size)
+int fsi_slave_claim_range(struct fsi_slave *slave,
+                         uint32_t addr, uint32_t size)
 {
        if (addr + size < addr)
                return -EINVAL;
@@ -406,8 +406,8 @@ extern int fsi_slave_claim_range(struct fsi_slave *slave,
 }
 EXPORT_SYMBOL_GPL(fsi_slave_claim_range);
 
-extern void fsi_slave_release_range(struct fsi_slave *slave,
-               uint32_t addr, uint32_t size)
+void fsi_slave_release_range(struct fsi_slave *slave,
+                            uint32_t addr, uint32_t size)
 {
 }
 EXPORT_SYMBOL_GPL(fsi_slave_release_range);