EDAC/device: Remove edac_dev_sysfs_block_attribute::{block,value}
authorJiri Slaby (SUSE) <jirislaby@kernel.org>
Tue, 13 Feb 2024 11:20:46 +0000 (12:20 +0100)
committerBorislav Petkov (AMD) <bp@alien8.de>
Wed, 27 Mar 2024 17:26:57 +0000 (18:26 +0100)
They're unused. And they were never used since their addition in

  fd309a9d8e63 ("drivers/edac: fix leaf sysfs attribute")

Drop it.

Found by https://github.com/jirislaby/clang-struct.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20240213112051.27715-3-jirislaby@kernel.org
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
drivers/edac/edac_device.c
drivers/edac/edac_device.h

index 0689e15107213c6a11b70b3460a78db17c3663b1..0e18729111d440fe583c3e9d9dae1f790ce9d2bf 100644 (file)
@@ -162,8 +162,6 @@ edac_device_alloc_ctl_info(unsigned pvt_sz, char *dev_name, unsigned nr_instance
                                attrib->show = attrib_spec[attr].show;
                                attrib->store = attrib_spec[attr].store;
 
-                               attrib->block = blk;    /* up link */
-
                                edac_dbg(4, "alloc-attrib=%p attrib_name='%s' attrib-spec=%p spec-name=%s\n",
                                         attrib, attrib->attr.name,
                                         &attrib_spec[attr],
index 7db22a4c83ef3f521aa5447759182b227171b668..c4704b5b1e9f98874e74af69d02fccb54d80c3e3 100644 (file)
@@ -99,18 +99,12 @@ struct edac_dev_sysfs_attribute {
  *     can have an array of the following. The show and store functions
  *     will be filled in with the show/store function in the
  *     low level driver.
- *
- *     The 'value' field will be the actual value field used for
- *     counting
  */
 struct edac_dev_sysfs_block_attribute {
        struct attribute attr;
        ssize_t (*show)(struct kobject *, struct attribute *, char *);
        ssize_t (*store)(struct kobject *, struct attribute *,
                        const char *, size_t);
-       struct edac_device_block *block;
-
-       unsigned int value;
 };
 
 /* device block control structure */