nvdimm/namespace: return uuid_null only once in nd_dev_to_uuid()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 7 Jun 2022 15:25:25 +0000 (18:25 +0300)
committerDan Williams <dan.j.williams@intel.com>
Thu, 14 Jul 2022 18:23:36 +0000 (11:23 -0700)
Refactor nd_dev_to_uuid() in order to make code shorter and cleaner
by joining conditions and hence returning uuid_null only once.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20220607152525.33468-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/nvdimm/namespace_devs.c

index bf4f5c09d9b1b3685eb359b64733335d729061fc..3dae17c90e8cf32c628252635a10cd3a81038c24 100644 (file)
@@ -170,15 +170,12 @@ EXPORT_SYMBOL(nvdimm_namespace_disk_name);
 
 const uuid_t *nd_dev_to_uuid(struct device *dev)
 {
-       if (!dev)
-               return &uuid_null;
-
-       if (is_namespace_pmem(dev)) {
+       if (dev && is_namespace_pmem(dev)) {
                struct nd_namespace_pmem *nspm = to_nd_namespace_pmem(dev);
 
                return nspm->uuid;
-       } else
-               return &uuid_null;
+       }
+       return &uuid_null;
 }
 EXPORT_SYMBOL(nd_dev_to_uuid);