ASoC: simple-card-utils: Avoid over-allocating DLCs
authorSamuel Holland <samuel@sholland.org>
Thu, 5 Aug 2021 05:07:06 +0000 (00:07 -0500)
committerMark Brown <broonie@kernel.org>
Thu, 5 Aug 2021 14:38:56 +0000 (15:38 +0100)
The allocation of the DAI link components (DLCs) passed the wrong
pointer to sizeof. Since simple_dai_props is much larger than
snd_soc_dai_link_component, there was no out of bounds access, only
wasted memory.

Fixes: f2138aed231c8 ("ASoC: simple-card-utils: enable flexible CPU/Codec/Platform")
Fixes: 050c7950fd706 ("ASoC: simple-card-utils: alloc dai_link information for CPU/Codec/Platform")
Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Samuel Holland <samuel@sholland.org>
Link: https://lore.kernel.org/r/20210805050706.46833-1-samuel@sholland.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/generic/simple-card-utils.c

index 677f7da93b4bb86aa53b9e08e1ad596c227a33cc..10c63b73900c66d2159c070260e0e6a4c65e7f90 100644 (file)
@@ -640,8 +640,8 @@ int asoc_simple_init_priv(struct asoc_simple_priv *priv,
                        cnf_num += li->num[i].codecs;
        }
 
-       dais = devm_kcalloc(dev, dai_num, sizeof(*dais),      GFP_KERNEL);
-       dlcs = devm_kcalloc(dev, dlc_num, sizeof(*dai_props), GFP_KERNEL);
+       dais = devm_kcalloc(dev, dai_num, sizeof(*dais), GFP_KERNEL);
+       dlcs = devm_kcalloc(dev, dlc_num, sizeof(*dlcs), GFP_KERNEL);
        if (!dais || !dlcs)
                return -ENOMEM;