usb: dwc3: keystone: Simplify with dev_err_probe()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 11 Jan 2021 13:55:39 +0000 (15:55 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Jan 2021 11:50:45 +0000 (12:50 +0100)
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.

Acked-by: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20210111135539.57234-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/dwc3-keystone.c

index 9a99253d5ba3be3a428c04ce491fed06e1003c2c..057056c0975e4a7a935b710c557d971f218d8123 100644 (file)
@@ -99,13 +99,8 @@ static int kdwc3_probe(struct platform_device *pdev)
 
        /* PSC dependency on AM65 needs SERDES0 to be powered before USB0 */
        kdwc->usb3_phy = devm_phy_optional_get(dev, "usb3-phy");
-       if (IS_ERR(kdwc->usb3_phy)) {
-               error = PTR_ERR(kdwc->usb3_phy);
-               if (error != -EPROBE_DEFER)
-                       dev_err(dev, "couldn't get usb3 phy: %d\n", error);
-
-               return error;
-       }
+       if (IS_ERR(kdwc->usb3_phy))
+               return dev_err_probe(dev, PTR_ERR(kdwc->usb3_phy), "couldn't get usb3 phy\n");
 
        phy_pm_runtime_get_sync(kdwc->usb3_phy);