net: ethernet: bgmac: Use devm_platform_ioremap_resource_byname
authorYang Yingliang <yangyingliang@huawei.com>
Mon, 7 Jun 2021 14:21:09 +0000 (22:21 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 7 Jun 2021 21:07:22 +0000 (14:07 -0700)
Use the devm_platform_ioremap_resource_byname() helper instead of
calling platform_get_resource_byname() and devm_ioremap_resource()
separately.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bgmac-platform.c

index 9834b77cf4b6e8806f9438608f80c10e6f973ddb..4ab5bf64d353e35761d468c90394cb6a4e05cfd2 100644 (file)
@@ -172,7 +172,6 @@ static int bgmac_probe(struct platform_device *pdev)
 {
        struct device_node *np = pdev->dev.of_node;
        struct bgmac *bgmac;
-       struct resource *regs;
        int ret;
 
        bgmac = bgmac_alloc(&pdev->dev);
@@ -206,21 +205,15 @@ static int bgmac_probe(struct platform_device *pdev)
        if (IS_ERR(bgmac->plat.base))
                return PTR_ERR(bgmac->plat.base);
 
-       regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, "idm_base");
-       if (regs) {
-               bgmac->plat.idm_base = devm_ioremap_resource(&pdev->dev, regs);
-               if (IS_ERR(bgmac->plat.idm_base))
-                       return PTR_ERR(bgmac->plat.idm_base);
+       bgmac->plat.idm_base = devm_platform_ioremap_resource_byname(pdev, "idm_base");
+       if (IS_ERR(bgmac->plat.idm_base))
+               return PTR_ERR(bgmac->plat.idm_base);
+       else
                bgmac->feature_flags &= ~BGMAC_FEAT_IDM_MASK;
-       }
 
-       regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, "nicpm_base");
-       if (regs) {
-               bgmac->plat.nicpm_base = devm_ioremap_resource(&pdev->dev,
-                                                              regs);
-               if (IS_ERR(bgmac->plat.nicpm_base))
-                       return PTR_ERR(bgmac->plat.nicpm_base);
-       }
+       bgmac->plat.nicpm_base = devm_platform_ioremap_resource_byname(pdev, "nicpm_base");
+       if (IS_ERR(bgmac->plat.nicpm_base))
+               return PTR_ERR(bgmac->plat.nicpm_base);
 
        bgmac->read = platform_bgmac_read;
        bgmac->write = platform_bgmac_write;