perf script: Allow --time with --reltime
authorAndi Kleen <ak@linux.intel.com>
Wed, 2 Oct 2019 16:46:42 +0000 (09:46 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 7 Oct 2019 15:22:18 +0000 (12:22 -0300)
The original --reltime patch forbid --time with --reltime.

But it turns out --time doesn't really care about --reltime, because the
relative time is only used at final output, while the time filtering
always works earlier on absolute time.

So just remove the check and allow combining the two options.

Fixes: 90b10f47c0ee ("perf script: Support relative time")
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Link: http://lore.kernel.org/lkml/20191002164642.1719-1-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-script.c

index 67be8d31afab60f0c543a9517b850af43e0b5191..1c797a948adaf9098618f38517098b97480434b4 100644 (file)
@@ -3605,11 +3605,6 @@ int cmd_script(int argc, const char **argv)
                }
        }
 
-       if (script.time_str && reltime) {
-               fprintf(stderr, "Don't combine --reltime with --time\n");
-               return -1;
-       }
-
        if (itrace_synth_opts.callchain &&
            itrace_synth_opts.callchain_sz > scripting_max_stack)
                scripting_max_stack = itrace_synth_opts.callchain_sz;