PCI: rcar-host: Drop error data fabrication when config read fails

If config pci_ops.read() methods return failure, the PCI_OP_READ() and
PCI_USER_READ_CONFIG() wrappers use PCI_SET_ERROR_RESPONSE() to set the
data value, so there's no need to set it in the pci_ops.read() methods
themselves.

Drop the unnecessary data value fabrication when pci_ops.read() fails.

Link: https://lore.kernel.org/r/83540eb3ae76a0d28bbe03d69d685a6d549b456b.1637243717.git.naveennaidu479@gmail.com
Signed-off-by: Naveen Naidu <naveennaidu479@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

diff --git a/drivers/pci/controller/pcie-rcar-host.c b/drivers/pci/controller/pcie-rcar-host.c
index e12c2d8be05a34e2b189e349934e3a4deb98c7bc..6bd5619fbbf48773beb3b6dfa05f3bcbb0cc4be8 100644 (file)
--- a/drivers/pci/controller/pcie-rcar-host.c
+++ b/drivers/pci/controller/pcie-rcar-host.c
@@ -159,10 +159,8 @@ static int rcar_pcie_read_conf(struct pci_bus *bus, unsigned int devfn,
 
        ret = rcar_pcie_config_access(host, RCAR_PCI_ACCESS_READ,
                                      bus, devfn, where, val);
-       if (ret != PCIBIOS_SUCCESSFUL) {
-               *val = 0xffffffff;
+       if (ret != PCIBIOS_SUCCESSFUL)
                return ret;
-       }
 
        if (size == 1)
                *val = (*val >> (BITS_PER_BYTE * (where & 3))) & 0xff;