ASoC: SOF: ipc4: Add flag to skip triggering pipelines during FE DAI trigger

Add a new flag, skip_during_fe_trigger, to struct sof_ipc4_pipeline to
skip triggering pipelines in the FE DAI trigger. Set this flag for the
HDA DAI BE pipelines so that their BE pipeline will not be triggered in
the FE DAI trigger. Also, move the trigger handling for all commands
include START/PAUSE_RELEASE for the HDA DAI's to the backend DAI trigger
ops.

For the SSP/DMIC/SDW cases, remove the BE DAI trigger as they involve no
DMA operations and can be triggered in the FE DAI trigger. This is in
preparation to perform batch triggering of all pipelines for the non-HDA
case.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Libin Yang <libin.yang@intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230127120031.10709-10-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/sof/intel/hda-dai.c b/sound/soc/sof/intel/hda-dai.c
index 1c3d4887aa304c15d1f56a39b3ef1a4cae308b40..98eebb4b07e6d3e14b2b493eac0a067f61822c35 100644 (file)
--- a/sound/soc/sof/intel/hda-dai.c
+++ b/sound/soc/sof/intel/hda-dai.c
@@ -450,6 +450,8 @@ static int ipc4_hda_dai_trigger(struct snd_pcm_substream *substream,
 {
        struct hdac_ext_stream *hext_stream = snd_soc_dai_get_dma_data(dai, substream);
        struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(dai->component);
+       struct snd_sof_widget *pipe_widget;
+       struct sof_ipc4_pipeline *pipeline;
        struct snd_soc_pcm_runtime *rtd;
        struct snd_sof_widget *swidget;
        struct snd_soc_dapm_widget *w;
@@ -466,18 +468,30 @@ static int ipc4_hda_dai_trigger(struct snd_pcm_substream *substream,
 
        w = snd_soc_dai_get_widget(dai, substream->stream);
        swidget = w->dobj.private;
+       pipe_widget = swidget->pipe_widget;
+       pipeline = pipe_widget->private;
 
        switch (cmd) {
        case SNDRV_PCM_TRIGGER_START:
        case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
                snd_hdac_ext_stream_start(hext_stream);
+               if (pipeline->state != SOF_IPC4_PIPE_PAUSED) {
+                       ret = sof_ipc4_set_pipeline_state(sdev, pipe_widget->instance_id,
+                                                         SOF_IPC4_PIPE_PAUSED);
+                       if (ret < 0)
+                               return ret;
+                       pipeline->state = SOF_IPC4_PIPE_PAUSED;
+               }
+
+               ret = sof_ipc4_set_pipeline_state(sdev, pipe_widget->instance_id,
+                                                 SOF_IPC4_PIPE_RUNNING);
+               if (ret < 0)
+                       return ret;
+               pipeline->state = SOF_IPC4_PIPE_RUNNING;
                break;
        case SNDRV_PCM_TRIGGER_SUSPEND:
        case SNDRV_PCM_TRIGGER_STOP:
        {
-               struct snd_sof_widget *pipe_widget = swidget->pipe_widget;
-               struct sof_ipc4_pipeline *pipeline = pipe_widget->private;
-
                ret = sof_ipc4_set_pipeline_state(sdev, pipe_widget->instance_id,
                                                  SOF_IPC4_PIPE_PAUSED);
                if (ret < 0)
@@ -503,9 +517,6 @@ static int ipc4_hda_dai_trigger(struct snd_pcm_substream *substream,
        }
        case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
        {
-               struct snd_sof_widget *pipe_widget = swidget->pipe_widget;
-               struct sof_ipc4_pipeline *pipeline = pipe_widget->private;
-
                ret = sof_ipc4_set_pipeline_state(sdev, pipe_widget->instance_id,
                                                  SOF_IPC4_PIPE_PAUSED);
                if (ret < 0)
@@ -703,64 +714,6 @@ static const struct snd_soc_dai_ops ipc3_ssp_dai_ops = {
        .shutdown = ssp_dai_shutdown,
 };
 
-static int ipc4_be_dai_common_trigger(struct snd_soc_dai *dai, int cmd, int stream)
-{
-       struct snd_sof_widget *pipe_widget;
-       struct sof_ipc4_pipeline *pipeline;
-       struct snd_sof_widget *swidget;
-       struct snd_soc_dapm_widget *w;
-       struct snd_sof_dev *sdev;
-       int ret;
-
-       w = snd_soc_dai_get_widget(dai, stream);
-       swidget = w->dobj.private;
-       pipe_widget = swidget->pipe_widget;
-       pipeline = pipe_widget->private;
-       sdev = snd_soc_component_get_drvdata(swidget->scomp);
-
-       switch (cmd) {
-       case SNDRV_PCM_TRIGGER_SUSPEND:
-       case SNDRV_PCM_TRIGGER_STOP:
-               ret = sof_ipc4_set_pipeline_state(sdev, pipe_widget->instance_id,
-                                                 SOF_IPC4_PIPE_PAUSED);
-               if (ret < 0)
-                       return ret;
-               pipeline->state = SOF_IPC4_PIPE_PAUSED;
-
-               ret = sof_ipc4_set_pipeline_state(sdev, pipe_widget->instance_id,
-                                                 SOF_IPC4_PIPE_RESET);
-               if (ret < 0)
-                       return ret;
-               pipeline->state = SOF_IPC4_PIPE_RESET;
-               break;
-       case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
-               ret = sof_ipc4_set_pipeline_state(sdev, pipe_widget->instance_id,
-                                                 SOF_IPC4_PIPE_PAUSED);
-               if (ret < 0)
-                       return ret;
-               pipeline->state = SOF_IPC4_PIPE_PAUSED;
-               break;
-       default:
-               break;
-       }
-
-       return 0;
-}
-
-static int ipc4_be_dai_trigger(struct snd_pcm_substream *substream,
-                              int cmd, struct snd_soc_dai *dai)
-{
-       return ipc4_be_dai_common_trigger(dai, cmd, substream->stream);
-}
-
-static const struct snd_soc_dai_ops ipc4_dmic_dai_ops = {
-       .trigger = ipc4_be_dai_trigger,
-};
-
-static const struct snd_soc_dai_ops ipc4_ssp_dai_ops = {
-       .trigger = ipc4_be_dai_trigger,
-};
-
 void hda_set_dai_drv_ops(struct snd_sof_dev *sdev, struct snd_sof_dsp_ops *ops)
 {
        int i;
@@ -785,14 +738,6 @@ void hda_set_dai_drv_ops(struct snd_sof_dev *sdev, struct snd_sof_dsp_ops *ops)
                struct sof_ipc4_fw_data *ipc4_data = sdev->private;
 
                for (i = 0; i < ops->num_drv; i++) {
-                       if (strstr(ops->drv[i].name, "DMIC")) {
-                               ops->drv[i].ops = &ipc4_dmic_dai_ops;
-                               continue;
-                       }
-                       if (strstr(ops->drv[i].name, "SSP")) {
-                               ops->drv[i].ops = &ipc4_ssp_dai_ops;
-                               continue;
-                       }
 #if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_AUDIO_CODEC)
                        if (strstr(ops->drv[i].name, "iDisp") ||
                            strstr(ops->drv[i].name, "Analog") ||
@@ -804,9 +749,6 @@ void hda_set_dai_drv_ops(struct snd_sof_dev *sdev, struct snd_sof_dsp_ops *ops)
                if (!hda_use_tplg_nhlt)
                        ipc4_data->nhlt = intel_nhlt_init(sdev->dev);
 
-               if (IS_ENABLED(CONFIG_SND_SOC_SOF_INTEL_SOUNDWIRE))
-                       sdw_callback.trigger = ipc4_be_dai_common_trigger;
-
                break;
        }
        default:

diff --git a/sound/soc/sof/ipc4-pcm.c b/sound/soc/sof/ipc4-pcm.c
index 05515e8e6f57a2872173232362688de31c72c661..db9d0adb2717b0338706b1e90ba52341973d012a 100644 (file)
--- a/sound/soc/sof/ipc4-pcm.c
+++ b/sound/soc/sof/ipc4-pcm.c
@@ -58,25 +58,10 @@ static int sof_ipc4_trigger_pipelines(struct snd_soc_component *component,
                if (!swidget)
                        continue;
 
-               /*
-                * set pipeline state for both FE and BE pipelines for RUNNING state.
-                * For PAUSE/RESET, set the pipeline state only for the FE pipeline.
-                */
-               switch (state) {
-               case SOF_IPC4_PIPE_PAUSED:
-               case SOF_IPC4_PIPE_RESET:
-                       if (!WIDGET_IS_AIF(swidget->id))
-                               continue;
-                       break;
-               default:
-                       break;
-               }
-
-               /* find pipeline widget for the pipeline that this widget belongs to */
                pipeline_widget = swidget->pipe_widget;
                pipeline = (struct sof_ipc4_pipeline *)pipeline_widget->private;
 
-               if (pipeline->state == state)
+               if (pipeline->state == state || pipeline->skip_during_fe_trigger)
                        continue;
 
                /* first set the pipeline to PAUSED state */

diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c
index b07a405516b132f60f666f950365954a25d22501..f3b1a7f81216e95849df444e6dfc4d61c4f9a1ae 100644 (file)
--- a/sound/soc/sof/ipc4-topology.c
+++ b/sound/soc/sof/ipc4-topology.c
@@ -1869,6 +1869,7 @@ static int sof_ipc4_dai_config(struct snd_sof_dev *sdev, struct snd_sof_widget *
        case SOF_DAI_INTEL_HDA:
                gtw_attr = ipc4_copier->gtw_attr;
                gtw_attr->lp_buffer_alloc = pipeline->lp_mode;
+               pipeline->skip_during_fe_trigger = true;
                fallthrough;
        case SOF_DAI_INTEL_ALH:
                copier_data->gtw_cfg.node_id &= ~SOF_IPC4_NODE_INDEX_MASK;

diff --git a/sound/soc/sof/ipc4-topology.h b/sound/soc/sof/ipc4-topology.h
index 8dbbf69b0eb79401a5f5b26db28c595406264ada..028b5d91b9db4db972be21e01e6b5489a22305ac 100644 (file)
--- a/sound/soc/sof/ipc4-topology.h
+++ b/sound/soc/sof/ipc4-topology.h
@@ -73,6 +73,7 @@
  * @mem_usage: Memory usage
  * @state: Pipeline state
  * @msg: message structure for pipeline
+ * @skip_during_fe_trigger: skip triggering this pipeline during the FE DAI trigger
  */
 struct sof_ipc4_pipeline {
        uint32_t priority;
@@ -80,6 +81,7 @@ struct sof_ipc4_pipeline {
        uint32_t mem_usage;
        int state;
        struct sof_ipc4_msg msg;
+       bool skip_during_fe_trigger;
 };
 
 /**