brcmfmac: fix error return code in brcmf_cfg80211_connect()

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 3b1e0a7bdfee ("brcmfmac: add support for SAE authentication offload")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Reviewed-by: Chi-hsien Lin <chi-hsien.lin@infineon.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1605248896-16812-1-git-send-email-zhangchangzhong@huawei.com

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index a2dbbb977d0cb78490ac98d525e294b051d26660..0ee421f30aa249f50a71d5530b6b9891310518bf 100644 (file)
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -2137,7 +2137,8 @@ brcmf_cfg80211_connect(struct wiphy *wiphy, struct net_device *ndev,
                                    BRCMF_WSEC_MAX_PSK_LEN);
        else if (profile->use_fwsup == BRCMF_PROFILE_FWSUP_SAE) {
                /* clean up user-space RSNE */
-               if (brcmf_fil_iovar_data_set(ifp, "wpaie", NULL, 0)) {
+               err = brcmf_fil_iovar_data_set(ifp, "wpaie", NULL, 0);
+               if (err) {
                        bphy_err(drvr, "failed to clean up user-space RSNE\n");
                        goto done;
                }