hw: fix using 4.2 compat in 5.0 machine types for i440fx/q35
authorDenis Plotnikov <dplotnikov@virtuozzo.com>
Mon, 23 Dec 2019 07:28:56 +0000 (10:28 +0300)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 7 Jan 2020 11:08:39 +0000 (12:08 +0100)
5.0 machine type uses 4.2 compats. This seems to be incorrect, since
the latests machine type by now is 5.0 and it should use its own
compat or shouldn't use any relying on the defaults.
Seems, like this appeared because of some problems on merge/rebase.

Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20191223072856.5369-1-dplotnikov@virtuozzo.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/i386/pc_piix.c
hw/i386/pc_q35.c

index 721c7aa64e1166ed7afdcb1fa11f9bd42b74f423..fa122030793f37fd55bb00804d18c3a7064c3dae 100644 (file)
@@ -425,7 +425,6 @@ static void pc_i440fx_5_0_machine_options(MachineClass *m)
     m->alias = "pc";
     m->is_default = 1;
     pcmc->default_cpu_version = 1;
-    compat_props_add(m->compat_props, hw_compat_4_2, hw_compat_4_2_len);
 }
 
 DEFINE_I440FX_MACHINE(v5_0, "pc-i440fx-5.0", NULL,
index 52f45735e4ffe44bfc1f07d0f2a76cc8bd7ebb01..84cf925cf43a00decfc76cd1fae75473df2f14c9 100644 (file)
@@ -354,7 +354,6 @@ static void pc_q35_5_0_machine_options(MachineClass *m)
     pc_q35_machine_options(m);
     m->alias = "q35";
     pcmc->default_cpu_version = 1;
-    compat_props_add(m->compat_props, hw_compat_4_2, hw_compat_4_2_len);
 }
 
 DEFINE_Q35_MACHINE(v5_0, "pc-q35-5.0", NULL,