ACPI: APEI: Remove unneeded result variables
authorye xingchen <ye.xingchen@zte.com.cn>
Wed, 21 Sep 2022 09:28:34 +0000 (09:28 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Sat, 24 Sep 2022 16:50:42 +0000 (18:50 +0200)
Return the erst_get_record_id_begin() and apei_exec_write_register()
return values directly instead of storing them in redundant local
variables.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
[ rjw: Changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/apei/apei-base.c
drivers/acpi/apei/erst.c

index 9f49272cad392b69e973a6555029438d373e0c3e..9b52482b4ed5ee7ddec61556c9b6ae540a9b1989 100644 (file)
@@ -125,12 +125,9 @@ EXPORT_SYMBOL_GPL(apei_exec_write_register);
 int apei_exec_write_register_value(struct apei_exec_context *ctx,
                                   struct acpi_whea_header *entry)
 {
-       int rc;
-
        ctx->value = entry->value;
-       rc = apei_exec_write_register(ctx, entry);
 
-       return rc;
+       return apei_exec_write_register(ctx, entry);
 }
 EXPORT_SYMBOL_GPL(apei_exec_write_register_value);
 
index 31b077eedb584860e14452e15aabab66481198a9..247989060e2917a419d3082963ce188fdfeb4828 100644 (file)
@@ -1020,14 +1020,10 @@ static int reader_pos;
 
 static int erst_open_pstore(struct pstore_info *psi)
 {
-       int rc;
-
        if (erst_disable)
                return -ENODEV;
 
-       rc = erst_get_record_id_begin(&reader_pos);
-
-       return rc;
+       return erst_get_record_id_begin(&reader_pos);
 }
 
 static int erst_close_pstore(struct pstore_info *psi)