drm/shmem-helper: Put booleans in the end of struct drm_gem_shmem_object
authorDmitry Osipenko <dmitry.osipenko@collabora.com>
Fri, 18 Nov 2022 16:13:43 +0000 (19:13 +0300)
committerDmitry Osipenko <dmitry.osipenko@collabora.com>
Mon, 27 Feb 2023 04:10:03 +0000 (07:10 +0300)
Group all 1-bit boolean members of struct drm_gem_shmem_object in the end
of the structure, allowing compiler to pack data better and making code to
look more consistent.

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Suggested-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Link: https://lore.kernel.org/all/20230108210445.3948344-5-dmitry.osipenko@collabora.com/
include/drm/drm_gem_shmem_helper.h

index a2201b2488c56ca4a4d8fae79d8d8acd0f18c7c5..5994fed5e3278dd11311d4cb4812b23b4cf43abb 100644 (file)
@@ -60,20 +60,6 @@ struct drm_gem_shmem_object {
         */
        struct list_head madv_list;
 
-       /**
-        * @pages_mark_dirty_on_put:
-        *
-        * Mark pages as dirty when they are put.
-        */
-       unsigned int pages_mark_dirty_on_put    : 1;
-
-       /**
-        * @pages_mark_accessed_on_put:
-        *
-        * Mark pages as accessed when they are put.
-        */
-       unsigned int pages_mark_accessed_on_put : 1;
-
        /**
         * @sgt: Scatter/gather table for imported PRIME buffers
         */
@@ -97,10 +83,24 @@ struct drm_gem_shmem_object {
         */
        unsigned int vmap_use_count;
 
+       /**
+        * @pages_mark_dirty_on_put:
+        *
+        * Mark pages as dirty when they are put.
+        */
+       bool pages_mark_dirty_on_put : 1;
+
+       /**
+        * @pages_mark_accessed_on_put:
+        *
+        * Mark pages as accessed when they are put.
+        */
+       bool pages_mark_accessed_on_put : 1;
+
        /**
         * @map_wc: map object write-combined (instead of using shmem defaults).
         */
-       bool map_wc;
+       bool map_wc : 1;
 };
 
 #define to_drm_gem_shmem_obj(obj) \