serial: 8250: Remove superfluous sanity check
authorLino Sanfilippo <l.sanfilippo@kunbus.com>
Sun, 7 Apr 2024 00:27:08 +0000 (02:27 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 9 Apr 2024 15:07:10 +0000 (17:07 +0200)
The serial core already checks the RS485 RTS settings for sanity, so remove
the superfluous check in serial8250_em485_config().

Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
Link: https://lore.kernel.org/r/20240407002709.16224-4-l.sanfilippo@kunbus.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_port.c

index 0c19451d0332f56c92d1b14d95de0d811057e944..893bc493f66252ae8ca5229e236da9ba6c81f6b0 100644 (file)
@@ -612,13 +612,6 @@ int serial8250_em485_config(struct uart_port *port, struct ktermios *termios,
 {
        struct uart_8250_port *up = up_to_u8250p(port);
 
-       /* pick sane settings if the user hasn't */
-       if (!!(rs485->flags & SER_RS485_RTS_ON_SEND) ==
-           !!(rs485->flags & SER_RS485_RTS_AFTER_SEND)) {
-               rs485->flags |= SER_RS485_RTS_ON_SEND;
-               rs485->flags &= ~SER_RS485_RTS_AFTER_SEND;
-       }
-
        /*
         * Both serial8250_em485_init() and serial8250_em485_destroy()
         * are idempotent.