power: supply: Remove redundant dev_err_probe() for platform_get_irq_byname()

There is no need to call the dev_err_probe() function directly to print
a custom message when handling an error from platform_get_irq_byname()
function as it is going to display an appropriate error message
in case of a failure.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Dhruva Gole <d-gole@ti.com>
Link: https://lore.kernel.org/r/20230727113550.2599335-1-ruanjinjie@huawei.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

diff --git a/drivers/power/supply/mt6370-charger.c b/drivers/power/supply/mt6370-charger.c
index f27dae5043f5b41704b26a635db355eab5305ec7..571cf00dde07b26b9dcd8d005c5aeeffb92b6982 100644 (file)
--- a/drivers/power/supply/mt6370-charger.c
+++ b/drivers/power/supply/mt6370-charger.c
@@ -849,9 +849,7 @@ static int mt6370_chg_init_irq(struct mt6370_priv *priv)
                ret = platform_get_irq_byname(to_platform_device(priv->dev),
                                              mt6370_chg_irqs[i].name);
                if (ret < 0)
-                       return dev_err_probe(priv->dev, ret,
-                                            "Failed to get irq %s\n",
-                                            mt6370_chg_irqs[i].name);
+                       return ret;
 
                priv->irq_nums[i] = ret;
                ret = devm_request_threaded_irq(priv->dev, ret, NULL,

diff --git a/drivers/power/supply/qcom_pmi8998_charger.c b/drivers/power/supply/qcom_pmi8998_charger.c
index 10f4dd0caca177bb4487bcaa850106c920611d54..8acf63ee6897f15d4b231240162e658fb9af76c1 100644 (file)
--- a/drivers/power/supply/qcom_pmi8998_charger.c
+++ b/drivers/power/supply/qcom_pmi8998_charger.c
@@ -915,8 +915,7 @@ static int smb2_init_irq(struct smb2_chip *chip, int *irq, const char *name,
 
        irqnum = platform_get_irq_byname(to_platform_device(chip->dev), name);
        if (irqnum < 0)
-               return dev_err_probe(chip->dev, irqnum,
-                                    "Couldn't get irq %s byname\n", name);
+               return irqnum;
 
        rc = devm_request_threaded_irq(chip->dev, irqnum, NULL, handler,
                                       IRQF_ONESHOT, name, chip);