pinctrl: realtek: Fix logical error when finding descriptor
authorTzuyi Chang <tychang@realtek.com>
Tue, 21 Nov 2023 09:11:07 +0000 (17:11 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 24 Nov 2023 09:39:20 +0000 (10:39 +0100)
The pin descriptor should be returned if the name has been found in the
descriptor table. Remove the negation in the if statement for accurate
retrieval.

Fixes: e99ce78030db ("pinctrl: realtek: Add common pinctrl driver for Realtek DHC RTD SoCs")
Signed-off-by: Tzuyi Chang <tychang@realtek.com>
Link: https://lore.kernel.org/r/20231121091107.5564-1-tychang@realtek.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/realtek/pinctrl-rtd.c

index 9c7a1af4ba692a965eef68a70f3dcd67e830da74..208896593b61ecdf584a13debc800686a6056328 100644 (file)
@@ -146,7 +146,7 @@ static int rtd_pinctrl_get_function_groups(struct pinctrl_dev *pcdev,
 
 static const struct rtd_pin_desc *rtd_pinctrl_find_mux(struct rtd_pinctrl *data, unsigned int pin)
 {
-       if (!data->info->muxes[pin].name)
+       if (data->info->muxes[pin].name)
                return &data->info->muxes[pin];
 
        return NULL;
@@ -249,7 +249,7 @@ static const struct pinctrl_pin_desc
 static const struct rtd_pin_config_desc
        *rtd_pinctrl_find_config(struct rtd_pinctrl *data, unsigned int pin)
 {
-       if (!data->info->configs[pin].name)
+       if (data->info->configs[pin].name)
                return &data->info->configs[pin];
 
        return NULL;