projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
133a08a
)
plip: avoid rcu debug splat
author
Florian Westphal
<fw@strlen.de>
Sun, 7 Aug 2022 11:53:04 +0000
(13:53 +0200)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Thu, 25 Aug 2022 09:40:11 +0000
(11:40 +0200)
commit
bc3c8fe3c79bcdae4d90e3726054fac5cca8ac32
upstream.
WARNING: suspicious RCU usage
5.2.0-rc2-00605-g2638eb8b50cfc
#1 Not tainted
drivers/net/plip/plip.c:1110 suspicious rcu_dereference_check() usage!
plip_open is called with RTNL held, switch to the correct helper.
Fixes: 2638eb8b50cf ("net: ipv4: provide __rcu annotation for ifa_list")
Reported-by: kernel test robot <oliver.sang@intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Link:
https://lore.kernel.org/r/20220807115304.13257-1-fw@strlen.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/plip/plip.c
patch
|
blob
|
history
diff --git
a/drivers/net/plip/plip.c
b/drivers/net/plip/plip.c
index 82d6094017113f225cbac76ead98c4fdb6ce8eb2..2a2cb9d453e8e2970c341d39210701e7b5f16bfe 100644
(file)
--- a/
drivers/net/plip/plip.c
+++ b/
drivers/net/plip/plip.c
@@
-1107,7
+1107,7
@@
plip_open(struct net_device *dev)
/* Any address will do - we take the first. We already
have the first two bytes filled with 0xfc, from
plip_init_dev(). */
- const struct in_ifaddr *ifa = r
cu
_dereference(in_dev->ifa_list);
+ const struct in_ifaddr *ifa = r
tnl
_dereference(in_dev->ifa_list);
if (ifa != NULL) {
memcpy(dev->dev_addr+2, &ifa->ifa_local, 4);
}