pmdomain: renesas: rmobile-sysc: fix -Wvoid-pointer-to-enum-cast warning
authorJustin Stitt <justinstitt@google.com>
Mon, 14 Aug 2023 22:11:28 +0000 (22:11 +0000)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 4 Oct 2023 21:41:57 +0000 (23:41 +0200)
When building with clang 18 I see the following warning:
|      drivers/soc/renesas/rmobile-sysc.c:193:22: warning: cast to smaller integer
|               type 'enum pd_types' from 'const void *' [-Wvoid-pointer-to-enum-cast]
|        193 |                 add_special_pd(np, (enum pd_types)id->data);

This is due to the fact that `id->data` is a void* and `enum pd_types`
has the size of an integer. This cast from pointer-width to int-width
causes truncation and possible data loss. Instead, cast to `uintptr_t`
which has the same width as void*.

Reported-by: Nathan Chancellor <nathan@kernel.org>
Closes: https://github.com/ClangBuiltLinux/linux/issues/1910
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20230814-void-drivers-soc-renesas-rmobile-sysc-v1-1-6648dfd854de@google.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/pmdomain/renesas/rmobile-sysc.c

index 912daadaa10d12e10e541656d71bc7cf403ced16..0b77f37787d58f48d7801208dcd2b5c8a1f17adb 100644 (file)
@@ -190,7 +190,7 @@ static void __init get_special_pds(void)
 
        /* PM domains containing other special devices */
        for_each_matching_node_and_match(np, special_ids, &id)
-               add_special_pd(np, (enum pd_types)id->data);
+               add_special_pd(np, (uintptr_t)id->data);
 }
 
 static void __init put_special_pds(void)