drm/i915/icl/tc: Remove the ICL special casing during TC-cold blocking
authorImre Deak <imre.deak@intel.com>
Tue, 21 Sep 2021 00:23:10 +0000 (03:23 +0300)
committerImre Deak <imre.deak@intel.com>
Wed, 29 Sep 2021 20:57:57 +0000 (23:57 +0300)
While a TypeC port mode is locked a DISPLAY_CORE power domain reference
is held, which implies a runtime PM ref. By removing the ICL !legacy
port special casing, a TC_COLD_OFF power domain reference will be taken
for such ports, which also translates to a runtime PM ref on that
platform. A follow-up change will stop holding the DISPLAY_CORE power
domain while the port is locked.

Cc: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210921002313.1132357-11-imre.deak@intel.com
drivers/gpu/drm/i915/display/intel_tc.c

index 2df4d0beb63687299a72880717f9ca0658526b4a..9367770de5d7926ceaf45bde27f127525ed74391 100644 (file)
@@ -71,9 +71,6 @@ tc_cold_block_in_mode(struct intel_digital_port *dig_port, enum tc_port_mode mod
 {
        struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
 
-       if (DISPLAY_VER(i915) == 11 && !dig_port->tc_legacy_port)
-               return 0;
-
        *domain = tc_cold_get_power_domain(dig_port, mode);
 
        return intel_display_power_get(i915, *domain);
@@ -108,9 +105,6 @@ assert_tc_cold_blocked(struct intel_digital_port *dig_port)
        struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
        bool enabled;
 
-       if (DISPLAY_VER(i915) == 11 && !dig_port->tc_legacy_port)
-               return;
-
        enabled = intel_display_power_is_enabled(i915,
                                                 tc_cold_get_power_domain(dig_port,
                                                                          dig_port->tc_mode));