projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
6105870
)
hwmon: (dell-smm) Use strscpy_pad()
author
Armin Wolf
<W_Armin@gmx.de>
Thu, 21 Oct 2021 19:05:28 +0000
(21:05 +0200)
committer
Guenter Roeck
<linux@roeck-us.net>
Thu, 21 Oct 2021 20:14:27 +0000
(13:14 -0700)
Using strscpy_pad() allows for fewer memory accesses
since memset() will not unconditionally zero-out
the whole buffer.
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Acked-by: Pali Rohár <pali@kernel.org>
Link:
https://lore.kernel.org/r/20211021190531.17379-3-W_Armin@gmx.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/dell-smm-hwmon.c
patch
|
blob
|
history
diff --git
a/drivers/hwmon/dell-smm-hwmon.c
b/drivers/hwmon/dell-smm-hwmon.c
index 9773d6c0477a65d0ec62cc982df31fbe401ed998..b0c591bb761af42e5732e06d6d6c6d9789ccdd23 100644
(file)
--- a/
drivers/hwmon/dell-smm-hwmon.c
+++ b/
drivers/hwmon/dell-smm-hwmon.c
@@
-25,6
+25,7
@@
#include <linux/platform_device.h>
#include <linux/proc_fs.h>
#include <linux/seq_file.h>
+#include <linux/string.h>
#include <linux/smp.h>
#include <linux/types.h>
#include <linux/uaccess.h>
@@
-472,8
+473,7
@@
i8k_ioctl_unlocked(struct file *fp, struct dell_smm_data *data, unsigned int cmd
if (restricted && !capable(CAP_SYS_ADMIN))
return -EPERM;
- memset(buff, 0, sizeof(buff));
- strscpy(buff, data->bios_machineid, sizeof(buff));
+ strscpy_pad(buff, data->bios_machineid, sizeof(buff));
break;
case I8K_FN_STATUS: