netdevsim: dev: Fix memory leak in nsim_dev_take_snapshot_write

In case memory resources for dummy_data were allocated, release them
before return.

Addresses-Coverity-ID: 1491997 ("Resource leak")
Fixes: 7ef19d3b1d5e ("devlink: report error once U32_MAX snapshot ids have been used")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
index 1fe2a93ad382fe856361f222cdcfd3aa502fef95..68668a22b9dda01be2d1de92b72a48e7279b1c97 100644 (file)
--- a/drivers/net/netdevsim/dev.c
+++ b/drivers/net/netdevsim/dev.c
@@ -75,6 +75,7 @@ static ssize_t nsim_dev_take_snapshot_write(struct file *file,
        err = devlink_region_snapshot_id_get(devlink, &id);
        if (err) {
                pr_err("Failed to get snapshot id\n");
+               kfree(dummy_data);
                return err;
        }
        err = devlink_region_snapshot_create(nsim_dev->dummy_region,