staging: use eth_hw_addr_set() for dev->addr_len cases

Convert all staging drivers from memcpy(... dev->addr_len)
to eth_hw_addr_set():

  @@
  expression dev, np;
  @@
  - memcpy(dev->dev_addr, np, dev->addr_len)
  + eth_hw_addr_set(dev, np)

Manually confirmed these are all etherdevices.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Link: https://lore.kernel.org/r/20211019171243.1412240-4-kuba@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
index 61d8f40e2739ff744dbed3c0e3d44845fb3c671f..7e8d37c169f0feb284e5fa7ff9214a444155e73f 100644 (file)
--- a/drivers/staging/ks7010/ks_wlan_net.c
+++ b/drivers/staging/ks7010/ks_wlan_net.c
@@ -2490,7 +2490,7 @@ int ks_wlan_set_mac_address(struct net_device *dev, void *addr)
 
        if (netif_running(dev))
                return -EBUSY;
-       memcpy(dev->dev_addr, mac_addr->sa_data, dev->addr_len);
+       eth_hw_addr_set(dev, mac_addr->sa_data);
        ether_addr_copy(priv->eth_addr, mac_addr->sa_data);
 
        priv->mac_address_valid = false;

diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index 8fcdf89da8aa9c65433f3dfd9a08d8cb573caaa4..abb7844f92fb03e9e2322d256f2ee0b23e610382 100644 (file)
--- a/drivers/staging/qlge/qlge_main.c
+++ b/drivers/staging/qlge/qlge_main.c
@@ -724,9 +724,7 @@ static int qlge_get_8000_flash_params(struct qlge_adapter *qdev)
                goto exit;
        }
 
-       memcpy(qdev->ndev->dev_addr,
-              mac_addr,
-              qdev->ndev->addr_len);
+       eth_hw_addr_set(qdev->ndev, mac_addr);
 
 exit:
        qlge_sem_unlock(qdev, SEM_FLASH_MASK);
@@ -774,9 +772,7 @@ static int qlge_get_8012_flash_params(struct qlge_adapter *qdev)
                goto exit;
        }
 
-       memcpy(qdev->ndev->dev_addr,
-              qdev->flash.flash_params_8012.mac_addr,
-              qdev->ndev->addr_len);
+       eth_hw_addr_set(qdev->ndev, qdev->flash.flash_params_8012.mac_addr);
 
 exit:
        qlge_sem_unlock(qdev, SEM_FLASH_MASK);
@@ -4214,7 +4210,7 @@ static int qlge_set_mac_address(struct net_device *ndev, void *p)
 
        if (!is_valid_ether_addr(addr->sa_data))
                return -EADDRNOTAVAIL;
-       memcpy(ndev->dev_addr, addr->sa_data, ndev->addr_len);
+       eth_hw_addr_set(ndev, addr->sa_data);
        /* Update local copy of current mac address. */
        memcpy(qdev->current_mac_addr, ndev->dev_addr, ndev->addr_len);
 

diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
index 07ed6c4cfdccc7ee6f5a5e5eff2cfafd1b6909a3..255500448ad3e6f28e2acb941d1b3af0284f657c 100644 (file)
--- a/drivers/staging/wlan-ng/p80211netdev.c
+++ b/drivers/staging/wlan-ng/p80211netdev.c
@@ -616,7 +616,7 @@ static int p80211knetdev_set_mac_address(struct net_device *dev, void *addr)
                result = -EADDRNOTAVAIL;
        } else {
                /* everything's ok, change the addr in netdev */
-               memcpy(dev->dev_addr, new_addr->sa_data, dev->addr_len);
+               eth_hw_addr_set(dev, new_addr->sa_data);
        }
 
        return result;