drm/msm: remove exra drm_kms_helper_poll_init() call
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Tue, 7 Nov 2023 11:14:13 +0000 (13:14 +0200)
committerAbhinav Kumar <quic_abhinavk@quicinc.com>
Thu, 16 Nov 2023 20:57:04 +0000 (12:57 -0800)
It seems during rebases I have left a call to drm_kms_helper_poll_init()
which is not guarded by the (priv->kms_init) check. This leads to the
crash for the boards which don't have KMS output. Drop this call, as
there is a correctly guarded one next to the one being removed.

Fixes: 506efcba3129 ("drm/msm: carve out KMS code from msm_drv.c")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/566299/
Link: https://lore.kernel.org/r/20231107111413.2212942-1-dmitry.baryshkov@linaro.org
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
drivers/gpu/drm/msm/msm_drv.c

index b61ccea0532765680eeed5225a16b74db07d3a3b..841f9c102b28c0c63a91e6eff12e625df913a8a8 100644 (file)
@@ -286,8 +286,6 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv)
        if (ret)
                goto err_msm_uninit;
 
-       drm_kms_helper_poll_init(ddev);
-
        if (priv->kms_init) {
                drm_kms_helper_poll_init(ddev);
                msm_fbdev_setup(ddev);