rtc: m41t80: constify m41t80_rtc_ops
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 10 Jan 2021 23:17:46 +0000 (00:17 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sat, 16 Jan 2021 22:19:26 +0000 (23:19 +0100)
Use RTC_FEATURE_ALARM to signal to the core whether alarms are available
instead of changing the global struct rtc_class_ops, allowing to make it
const.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20210110231752.1418816-12-alexandre.belloni@bootlin.com
drivers/rtc/rtc-m41t80.c

index 160dcf68e64ebdf0fae40b57075b3d7e1a207b1d..e3ddd660d68c267cd3079643f2f4ed0bdf9fa686 100644 (file)
@@ -397,10 +397,13 @@ static int m41t80_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
        return 0;
 }
 
-static struct rtc_class_ops m41t80_rtc_ops = {
+static const struct rtc_class_ops m41t80_rtc_ops = {
        .read_time = m41t80_rtc_read_time,
        .set_time = m41t80_rtc_set_time,
        .proc = m41t80_rtc_proc,
+       .read_alarm = m41t80_read_alarm,
+       .set_alarm = m41t80_set_alarm,
+       .alarm_irq_enable = m41t80_alarm_irq_enable,
 };
 
 #ifdef CONFIG_PM_SLEEP
@@ -913,13 +916,10 @@ static int m41t80_probe(struct i2c_client *client,
                        wakeup_source = false;
                }
        }
-       if (client->irq > 0 || wakeup_source) {
-               m41t80_rtc_ops.read_alarm = m41t80_read_alarm;
-               m41t80_rtc_ops.set_alarm = m41t80_set_alarm;
-               m41t80_rtc_ops.alarm_irq_enable = m41t80_alarm_irq_enable;
-               /* Enable the wakealarm */
+       if (client->irq > 0 || wakeup_source)
                device_init_wakeup(&client->dev, true);
-       }
+       else
+               clear_bit(RTC_FEATURE_ALARM, m41t80_data->rtc->features);
 
        m41t80_data->rtc->ops = &m41t80_rtc_ops;
        m41t80_data->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000;