video: fbdev: da8xx-fb: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/drivers/video/fbdev/da8xx-fb.c b/drivers/video/fbdev/da8xx-fb.c
index 005ac3c17aa1f0696d38d132959e601ab8990497..ae76a2111c7741e646d45a0258eb052e88c17318 100644 (file)
--- a/drivers/video/fbdev/da8xx-fb.c
+++ b/drivers/video/fbdev/da8xx-fb.c
@@ -1354,10 +1354,9 @@ static int fb_probe(struct platform_device *device)
                return PTR_ERR(da8xx_fb_reg_base);
 
        tmp_lcdc_clk = devm_clk_get(&device->dev, "fck");
-       if (IS_ERR(tmp_lcdc_clk)) {
-               dev_err(&device->dev, "Can not get device clock\n");
-               return PTR_ERR(tmp_lcdc_clk);
-       }
+       if (IS_ERR(tmp_lcdc_clk))
+               return dev_err_probe(&device->dev, PTR_ERR(tmp_lcdc_clk),
+                                    "Can not get device clock\n");
 
        pm_runtime_enable(&device->dev);
        pm_runtime_get_sync(&device->dev);