md: remove mddev->queue

Just use the request_queue from the gendisk pointer in the relatively
few places that sill need it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed--by: Song Liu <song@kernel.org>
Tested-by: Song Liu <song@kernel.org>
Signed-off-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20240303140150.5435-11-hch@lst.de

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 4bc47ed2d7a8b93d70a5a0abae6785eed0ae3afa..7d7b982e369c11766d2d9998b4020fca9bb31ef4 100644 (file)
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -5770,10 +5770,10 @@ int mddev_stack_new_rdev(struct mddev *mddev, struct md_rdev *rdev)
        if (mddev_is_dm(mddev))
                return 0;
 
-       lim = queue_limits_start_update(mddev->queue);
+       lim = queue_limits_start_update(mddev->gendisk->queue);
        queue_limits_stack_bdev(&lim, rdev->bdev, rdev->data_offset,
                                mddev->gendisk->disk_name);
-       return queue_limits_commit_update(mddev->queue, &lim);
+       return queue_limits_commit_update(mddev->gendisk->queue, &lim);
 }
 EXPORT_SYMBOL_GPL(mddev_stack_new_rdev);
 
@@ -5877,8 +5877,7 @@ struct mddev *md_alloc(dev_t dev, char *name)
        disk->fops = &md_fops;
        disk->private_data = mddev;
 
-       mddev->queue = disk->queue;
-       blk_queue_write_cache(mddev->queue, true, true);
+       blk_queue_write_cache(disk->queue, true, true);
        disk->events |= DISK_EVENT_MEDIA_CHANGE;
        mddev->gendisk = disk;
        error = add_disk(disk);
@@ -6183,6 +6182,7 @@ int md_run(struct mddev *mddev)
        }
 
        if (!mddev_is_dm(mddev)) {
+               struct request_queue *q = mddev->gendisk->queue;
                bool nonrot = true;
 
                rdev_for_each(rdev, mddev) {
@@ -6194,14 +6194,14 @@ int md_run(struct mddev *mddev)
                if (mddev->degraded)
                        nonrot = false;
                if (nonrot)
-                       blk_queue_flag_set(QUEUE_FLAG_NONROT, mddev->queue);
+                       blk_queue_flag_set(QUEUE_FLAG_NONROT, q);
                else
-                       blk_queue_flag_clear(QUEUE_FLAG_NONROT, mddev->queue);
-               blk_queue_flag_set(QUEUE_FLAG_IO_STAT, mddev->queue);
+                       blk_queue_flag_clear(QUEUE_FLAG_NONROT, q);
+               blk_queue_flag_set(QUEUE_FLAG_IO_STAT, q);
 
                /* Set the NOWAIT flags if all underlying devices support it */
                if (nowait)
-                       blk_queue_flag_set(QUEUE_FLAG_NOWAIT, mddev->queue);
+                       blk_queue_flag_set(QUEUE_FLAG_NOWAIT, q);
        }
        if (pers->sync_request) {
                if (mddev->kobj.sd &&
@@ -6447,8 +6447,10 @@ static void mddev_detach(struct mddev *mddev)
                mddev->pers->quiesce(mddev, 0);
        }
        md_unregister_thread(mddev, &mddev->thread);
+
+       /* the unplug fn references 'conf' */
        if (!mddev_is_dm(mddev))
-               blk_sync_queue(mddev->queue); /* the unplug fn references 'conf'*/
+               blk_sync_queue(mddev->gendisk->queue);
 }
 
 static void __md_stop(struct mddev *mddev)
@@ -7166,7 +7168,7 @@ static int hot_add_disk(struct mddev *mddev, dev_t dev)
        if (!bdev_nowait(rdev->bdev)) {
                pr_info("%s: Disabling nowait because %pg does not support nowait\n",
                        mdname(mddev), rdev->bdev);
-               blk_queue_flag_clear(QUEUE_FLAG_NOWAIT, mddev->queue);
+               blk_queue_flag_clear(QUEUE_FLAG_NOWAIT, mddev->gendisk->queue);
        }
        /*
         * Kick recovery, maybe this spare has to be added to the

diff --git a/drivers/md/md.h b/drivers/md/md.h
index 0d1119be0b504199a47bb989ccfb96fa59193b27..67e50c44f4b517f3df8ebed80f1f2151dfa0d434 100644 (file)
--- a/drivers/md/md.h
+++ b/drivers/md/md.h
@@ -480,7 +480,6 @@ struct mddev {
        struct timer_list               safemode_timer;
        struct percpu_ref               writes_pending;
        int                             sync_checkers;  /* # of threads checking writes_pending */
-       struct request_queue            *queue; /* for plugging ... */
 
        struct bitmap                   *bitmap; /* the bitmap for the device */
        struct {
@@ -869,7 +868,7 @@ static inline void mddev_check_write_zeroes(struct mddev *mddev, struct bio *bio
 {
        if (bio_op(bio) == REQ_OP_WRITE_ZEROES &&
            !bio->bi_bdev->bd_disk->queue->limits.max_write_zeroes_sectors)
-               mddev->queue->limits.max_write_zeroes_sectors = 0;
+               mddev->gendisk->queue->limits.max_write_zeroes_sectors = 0;
 }
 
 static inline int mddev_suspend_and_lock(struct mddev *mddev)
@@ -932,7 +931,7 @@ static inline void mddev_trace_remap(struct mddev *mddev, struct bio *bio,
 #define mddev_add_trace_msg(mddev, fmt, args...)                       \
 do {                                                                   \
        if (!mddev_is_dm(mddev))                                        \
-               blk_add_trace_msg((mddev)->queue, fmt, ##args);         \
+               blk_add_trace_msg((mddev)->gendisk->queue, fmt, ##args); \
 } while (0)
 
 #endif /* _MD_MD_H */

diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
index f65aa6ecec0482e0969ff7d158e4bd52656d4af7..c5d4aeb68404c9cbd3f79797672013f965b45bbb 100644 (file)
--- a/drivers/md/raid0.c
+++ b/drivers/md/raid0.c
@@ -389,7 +389,7 @@ static int raid0_set_limits(struct mddev *mddev)
        lim.io_min = mddev->chunk_sectors << 9;
        lim.io_opt = lim.io_min * mddev->raid_disks;
        mddev_stack_rdev_limits(mddev, &lim);
-       return queue_limits_set(mddev->queue, &lim);
+       return queue_limits_set(mddev->gendisk->queue, &lim);
 }
 
 static int raid0_run(struct mddev *mddev)

diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index c349683783772078cb86cf43dba493ab926b8856..be8ac24f50b6ad651fd107f9af9a448bb1f7780a 100644 (file)
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -3201,7 +3201,7 @@ static int raid1_set_limits(struct mddev *mddev)
        blk_set_stacking_limits(&lim);
        lim.max_write_zeroes_sectors = 0;
        mddev_stack_rdev_limits(mddev, &lim);
-       return queue_limits_set(mddev->queue, &lim);
+       return queue_limits_set(mddev->gendisk->queue, &lim);
 }
 
 static void raid1_free(struct mddev *mddev, void *priv);

diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index e96fdf47319fd088de77c4e4b5ed10a62b711ccd..b0fd3005f5c18fca18dafa6ed8ac528c56bb9495 100644 (file)
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -3986,7 +3986,7 @@ static int raid10_set_queue_limits(struct mddev *mddev)
        lim.io_min = mddev->chunk_sectors << 9;
        lim.io_opt = lim.io_min * raid10_nr_stripes(conf);
        mddev_stack_rdev_limits(mddev, &lim);
-       return queue_limits_set(mddev->queue, &lim);
+       return queue_limits_set(mddev->gendisk->queue, &lim);
 }
 
 static int raid10_run(struct mddev *mddev)

diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c
index da4ba736c4f0c942e15fca6c4ce65649e82ffe93..a70cbec12ed01737874659ed2ac3c65987a5dc9f 100644 (file)
--- a/drivers/md/raid5-ppl.c
+++ b/drivers/md/raid5-ppl.c
@@ -1393,7 +1393,8 @@ int ppl_init_log(struct r5conf *conf)
                ppl_conf->signature = ~crc32c_le(~0, mddev->uuid, sizeof(mddev->uuid));
                ppl_conf->block_size = 512;
        } else {
-               ppl_conf->block_size = queue_logical_block_size(mddev->queue);
+               ppl_conf->block_size =
+                       queue_logical_block_size(mddev->gendisk->queue);
        }
 
        for (i = 0; i < ppl_conf->count; i++) {

diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 5012069782bab03a553957b13910874e55155037..f2e3c3e2d879fcdedab6e55d8cc7690e19eb2f7b 100644 (file)
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -4275,9 +4275,10 @@ static int handle_stripe_dirtying(struct r5conf *conf,
                        }
                }
                if (rcw && !mddev_is_dm(conf->mddev))
-                       blk_add_trace_msg(conf->mddev->queue, "raid5 rcw %llu %d %d %d",
-                                         (unsigned long long)sh->sector,
-                                         rcw, qread, test_bit(STRIPE_DELAYED, &sh->state));
+                       blk_add_trace_msg(conf->mddev->gendisk->queue,
+                               "raid5 rcw %llu %d %d %d",
+                               (unsigned long long)sh->sector, rcw, qread,
+                               test_bit(STRIPE_DELAYED, &sh->state));
        }
 
        if (rcw > disks && rmw > disks &&
@@ -5686,7 +5687,7 @@ static void raid5_unplug(struct blk_plug_cb *blk_cb, bool from_schedule)
        release_inactive_stripe_list(conf, cb->temp_inactive_list,
                                     NR_STRIPE_HASH_LOCKS);
        if (!mddev_is_dm(mddev))
-               trace_block_unplug(mddev->queue, cnt, !from_schedule);
+               trace_block_unplug(mddev->gendisk->queue, cnt, !from_schedule);
        kfree(cb);
 }
 
@@ -7089,7 +7090,7 @@ raid5_store_skip_copy(struct mddev *mddev, const char *page, size_t len)
        if (!conf)
                err = -ENODEV;
        else if (new != conf->skip_copy) {
-               struct request_queue *q = mddev->queue;
+               struct request_queue *q = mddev->gendisk->queue;
 
                conf->skip_copy = new;
                if (new)
@@ -7749,7 +7750,7 @@ static int raid5_set_limits(struct mddev *mddev)
        /* No restrictions on the number of segments in the request */
        lim.max_segments = USHRT_MAX;
 
-       return queue_limits_set(mddev->queue, &lim);
+       return queue_limits_set(mddev->gendisk->queue, &lim);
 }
 
 static int raid5_run(struct mddev *mddev)