Input: cap11xx - cache hardware ID registers
authorMark Brown <broonie@kernel.org>
Sat, 30 Sep 2023 23:43:38 +0000 (01:43 +0200)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 13 Dec 2023 05:39:09 +0000 (21:39 -0800)
The cap11xx devices have three hardware identification registers which are
currently marked as volatile, preventing caching of those registers. This
is not ideal since the registers should never change at runtime, we should
be able to cache the value after the first read. Stop marking the registers
as volatile, we don't have register defaults specified in the driver so
this will result in reading from the hardware on first use.

Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20231001-input-maple-v1-1-ed3716051431@kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/cap11xx.c

index ebcbc00d2059ef9f12243e51ef87eb25b06dba9f..8e25d7d5e64de1c4013e05b4c0eaecd889b464d3 100644 (file)
@@ -173,9 +173,6 @@ static bool cap11xx_volatile_reg(struct device *dev, unsigned int reg)
        case CAP11XX_REG_SENOR_DELTA(3):
        case CAP11XX_REG_SENOR_DELTA(4):
        case CAP11XX_REG_SENOR_DELTA(5):
-       case CAP11XX_REG_PRODUCT_ID:
-       case CAP11XX_REG_MANUFACTURER_ID:
-       case CAP11XX_REG_REVISION:
                return true;
        }