iommu/vt-d: Fix off-by-one in PASID allocation
authorJacob Pan <jacob.jun.pan@linux.intel.com>
Thu, 2 Jan 2020 00:18:07 +0000 (08:18 +0800)
committerJoerg Roedel <jroedel@suse.de>
Tue, 7 Jan 2020 13:05:57 +0000 (14:05 +0100)
PASID allocator uses IDR which is exclusive for the end of the
allocation range. There is no need to decrement pasid_max.

Fixes: af39507305fb ("iommu/vt-d: Apply global PASID in SVA")
Reported-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/intel-svm.c

index 48205ab1fea45abaa063a689e5c6ba399f5add58..9b32614910a5de90221792d69c69e56e37ab657d 100644 (file)
@@ -334,7 +334,7 @@ int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_
                /* Do not use PASID 0 in caching mode (virtualised IOMMU) */
                ret = intel_pasid_alloc_id(svm,
                                           !!cap_caching_mode(iommu->cap),
-                                          pasid_max - 1, GFP_KERNEL);
+                                          pasid_max, GFP_KERNEL);
                if (ret < 0) {
                        kfree(svm);
                        kfree(sdev);