drm/bridge/analogix/anx78xx: Drop ID table
authorBiju Das <biju.das.jz@bp.renesas.com>
Thu, 31 Aug 2023 08:09:35 +0000 (09:09 +0100)
committerDouglas Anderson <dianders@chromium.org>
Wed, 6 Sep 2023 15:32:28 +0000 (08:32 -0700)
The driver has an ID table, but it uses the wrong API for retrieving match
data and that will lead to a crash, if it is instantiated by user space or
using ID. From this, there is no user for the ID table and let's drop it
from the driver as it saves some memory.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Helen Koike <helen.koike@collabora.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230831080938.47454-2-biju.das.jz@bp.renesas.com
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c

index 800555aef97fb9af093006a222ef5e9db6d056b3..6169db73d2fe8ad0cd84b5143a6a2a9cc1b89c5f 100644 (file)
@@ -1367,12 +1367,6 @@ static void anx78xx_i2c_remove(struct i2c_client *client)
        kfree(anx78xx->edid);
 }
 
-static const struct i2c_device_id anx78xx_id[] = {
-       { "anx7814", 0 },
-       { /* sentinel */ }
-};
-MODULE_DEVICE_TABLE(i2c, anx78xx_id);
-
 static const struct of_device_id anx78xx_match_table[] = {
        { .compatible = "analogix,anx7808", .data = anx7808_i2c_addresses },
        { .compatible = "analogix,anx7812", .data = anx781x_i2c_addresses },
@@ -1389,7 +1383,6 @@ static struct i2c_driver anx78xx_driver = {
                  },
        .probe = anx78xx_i2c_probe,
        .remove = anx78xx_i2c_remove,
-       .id_table = anx78xx_id,
 };
 module_i2c_driver(anx78xx_driver);