mei: lower the log level for non-fatal failed messages
authorVitaly Lubart <vitaly.lubart@intel.com>
Tue, 7 Feb 2023 11:55:20 +0000 (13:55 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Feb 2023 12:24:46 +0000 (13:24 +0100)
Some non-fatal log messages should be logged at INFO log level
because failure to send/receive them is not breaking mei functionality
and may happen during legal firmware resets

Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Link: https://lore.kernel.org/r/20230207115520.846232-2-tomas.winkler@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mei/bus-fixup.c

index 92c0930cc742c8a29dfbc13bd358df1db84732d2..2115361093082156baa33c11666d36d83a0edb52 100644 (file)
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Copyright (c) 2013-2022, Intel Corporation. All rights reserved.
+ * Copyright (c) 2013-2023, Intel Corporation. All rights reserved.
  * Intel Management Engine Interface (Intel MEI) Linux driver
  */
 
@@ -151,7 +151,7 @@ static int mei_fwver(struct mei_cl_device *cldev)
        ret = __mei_cl_send(cldev->cl, (u8 *)&req, sizeof(req), 0,
                            MEI_CL_IO_TX_BLOCKING);
        if (ret < 0) {
-               dev_err(&cldev->dev, "Could not send ReqFWVersion cmd ret = %d\n", ret);
+               dev_info(&cldev->dev, "Could not send ReqFWVersion cmd ret = %d\n", ret);
                return ret;
        }
 
@@ -163,7 +163,7 @@ static int mei_fwver(struct mei_cl_device *cldev)
                 * Should be at least one version block,
                 * error out if nothing found
                 */
-               dev_err(&cldev->dev, "Could not read FW version ret = %d\n", bytes_recv);
+               dev_info(&cldev->dev, "Could not read FW version ret = %d\n", bytes_recv);
                return -EIO;
        }
 
@@ -220,15 +220,15 @@ static void mei_mkhi_fix(struct mei_cl_device *cldev)
        if (cldev->bus->fw_f_fw_ver_supported) {
                ret = mei_fwver(cldev);
                if (ret < 0)
-                       dev_err(&cldev->dev, "FW version command failed %d\n",
-                               ret);
+                       dev_info(&cldev->dev, "FW version command failed %d\n",
+                                ret);
        }
 
        if (cldev->bus->hbm_f_os_supported) {
                ret = mei_osver(cldev);
                if (ret < 0)
-                       dev_err(&cldev->dev, "OS version command failed %d\n",
-                               ret);
+                       dev_info(&cldev->dev, "OS version command failed %d\n",
+                                ret);
        }
        mei_cldev_disable(cldev);
 }
@@ -247,7 +247,7 @@ static void mei_gsc_mkhi_ver(struct mei_cl_device *cldev)
 
        ret = mei_fwver(cldev);
        if (ret < 0)
-               dev_err(&cldev->dev, "FW version command failed %d\n", ret);
+               dev_info(&cldev->dev, "FW version command failed %d\n", ret);
        mei_cldev_disable(cldev);
 }
 
@@ -278,8 +278,8 @@ static void mei_gsc_mkhi_fix_ver(struct mei_cl_device *cldev)
 
        ret = mei_fwver(cldev);
        if (ret < 0)
-               dev_err(&cldev->dev, "FW version command failed %d\n",
-                       ret);
+               dev_info(&cldev->dev, "FW version command failed %d\n",
+                        ret);
 out:
        mei_cldev_disable(cldev);
 }
@@ -403,7 +403,7 @@ static int mei_nfc_if_version(struct mei_cl *cl,
        memcpy(ver, reply->data, sizeof(*ver));
 
        dev_info(bus->dev, "NFC MEI VERSION: IVN 0x%x Vendor ID 0x%x Type 0x%x\n",
-               ver->fw_ivn, ver->vendor_id, ver->radio_type);
+                ver->fw_ivn, ver->vendor_id, ver->radio_type);
 
 err:
        kfree(reply);