scsi: qla4xxx: Remove redundant assignment to variable rval
authorColin Ian King <colin.king@canonical.com>
Fri, 4 Dec 2020 19:18:10 +0000 (19:18 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 9 Dec 2020 16:34:17 +0000 (11:34 -0500)
The variable rval is being initialized with a value that is never read and
it is being updated later with a new value.  The initialization is
redundant and can be removed.

Link: https://lore.kernel.org/r/20201204191810.1150995-1-colin.king@canonical.com
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Addresses-Coverity: ("Unused value")

drivers/scsi/qla4xxx/ql4_nx.c

index fd30fbd0d33cb43693610b6b73840bbc24a81181..e6e35e6958f6dfb66b550b0a8ce943fe1668cb46 100644 (file)
@@ -1767,7 +1767,7 @@ qla4_82xx_start_firmware(struct scsi_qla_host *ha, uint32_t image_start)
 
 int qla4_82xx_try_start_fw(struct scsi_qla_host *ha)
 {
-       int rval = QLA_ERROR;
+       int rval;
 
        /*
         * FW Load priority: