wifi: ath12k: fix conf_mutex in ath12k_mac_op_unassign_vif_chanctx()
authorWen Gong <quic_wgong@quicinc.com>
Tue, 13 Jun 2023 09:19:45 +0000 (12:19 +0300)
committerKalle Valo <quic_kvalo@quicinc.com>
Thu, 15 Jun 2023 11:35:40 +0000 (14:35 +0300)
"mutex_unlock(&ar->conf_mutex);" is always called at end of function
ath12k_mac_op_unassign_vif_chanctx(), so delete this unlock to make
sure lock/unlock is paired.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4

Signed-off-by: Wen Gong <quic_wgong@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230608104444.3134-1-quic_wgong@quicinc.com
drivers/net/wireless/ath/ath12k/mac.c

index a344211f5b536901b786f5ef82b6a17332f6ceda..1bb9802ef5696c26639f9a9159f24bc5a540ab2f 100644 (file)
@@ -5928,7 +5928,6 @@ ath12k_mac_op_unassign_vif_chanctx(struct ieee80211_hw *hw,
                }
 
                arvif->is_started = false;
-               mutex_unlock(&ar->conf_mutex);
        }
 
        ret = ath12k_mac_vdev_stop(arvif);