wifi: iwlwifi: mvm: remove chanctx WARN_ON
authorJohannes Berg <johannes.berg@intel.com>
Wed, 29 Mar 2023 07:05:26 +0000 (10:05 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Thu, 30 Mar 2023 10:08:41 +0000 (12:08 +0200)
During link switching there might be a link that's marked
active but has no chanctx assigned (so it's not active from
our driver's POV), skip such links in power recalculation
without any warning.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230329100039.c629090bd5d2.If7a680d5e349d454f2122f936c21522b9528a55f@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/power.c

index 2033d89dc9e5606ad85e66a52a25a75b617976e2..ac1dae52556f8b632d2126dd4a79845f70079965 100644 (file)
@@ -286,7 +286,8 @@ static bool iwl_mvm_power_is_radar(struct ieee80211_vif *vif)
        rcu_read_lock();
        for_each_vif_active_link(vif, link_conf, link_id) {
                chanctx_conf = rcu_dereference(link_conf->chanctx_conf);
-               if (WARN_ON(!chanctx_conf))
+               /* this happens on link switching, just ignore inactive ones */
+               if (!chanctx_conf)
                        continue;
 
                radar_detect = !!(chanctx_conf->def.chan->flags &